Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AS statement support for createTable #771

Merged
merged 3 commits into from
Nov 20, 2023
Merged

AS statement support for createTable #771

merged 3 commits into from
Nov 20, 2023

Conversation

viraxslot
Copy link
Contributor

Closes: #690

Done:

  • added support of as statement for createTable
  • added unit tests
  • added tests for typings

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 8:59am

@viraxslot viraxslot requested a review from koskimas November 20, 2023 09:40
@igalklebanov igalklebanov added enhancement New feature or request api Related to library's API labels Nov 20, 2023
koskimas
koskimas approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@koskimas koskimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems perfect! Thanks a lot!

@koskimas koskimas merged commit 31c5258 into kysely-org:master Nov 20, 2023
5 checks passed
@viraxslot viraxslot deleted the create-table-as-select branch November 20, 2023 17:30
@igalklebanov igalklebanov added postgres Related to PostgreSQL mysql Related to MySQL sqlite Related to sqlite labels Nov 20, 2023
@filipeoliveiraa filipeoliveiraa mentioned this pull request Aug 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koskimas koskimas koskimas approved these changes

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request mysql Related to MySQL postgres Related to PostgreSQL sqlite Related to sqlite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for CREATE TABLE table AS select_statement?
3 participants
@viraxslot @koskimas @igalklebanov